From 974133db8531c7edd9969c8ebb04470318fc767d Mon Sep 17 00:00:00 2001 From: "Serge A. Zaitsev" Date: Sun, 23 Sep 2012 20:29:48 +0300 Subject: [PATCH] tokens array items are now being initialized during allocation, removed redundant code that significantly slowed down the parser --- jsmn.c | 19 +++++++------------ jsmn_test.c | 4 ++-- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/jsmn.c b/jsmn.c index 761a604..9a96c4f 100644 --- a/jsmn.c +++ b/jsmn.c @@ -7,14 +7,14 @@ */ static jsmntok_t *jsmn_alloc_token(jsmn_parser *parser, jsmntok_t *tokens, size_t num_tokens) { - unsigned int i; - for (i = parser->toknext; i < num_tokens; i++) { - if (tokens[i].start == -1 && tokens[i].end == -1) { - parser->toknext = i + 1; - return &tokens[i]; - } + jsmntok_t *tok; + if (parser->toknext >= num_tokens) { + return NULL; } - return NULL; + tok = &tokens[parser->toknext++]; + tok->start = tok->end = -1; + tok->size = 0; + return tok; } /** @@ -128,11 +128,6 @@ jsmnerr_t jsmn_parse(jsmn_parser *parser, const char *js, jsmntok_t *tokens, unsigned int tokindex; jsmntok_t *token; - /* initialize the rest of tokens (they could be reallocated) */ - for (tokindex = parser->toknext; tokindex < num_tokens; tokindex++) { - jsmn_fill_token(&tokens[tokindex], JSMN_PRIMITIVE, -1, -1); - } - for (; js[parser->pos] != '\0'; parser->pos++) { char c; jsmntype_t type; diff --git a/jsmn_test.c b/jsmn_test.c index 0bbd82c..a33d6b8 100644 --- a/jsmn_test.c +++ b/jsmn_test.c @@ -156,13 +156,13 @@ int test_partial_string() { r = jsmn_parse(&p, js, tok, 10); check(r == JSMN_ERROR_PART && tok[0].type == JSMN_STRING); check(TOKEN_STRING(js, tok[0], "x")); - check(TOKEN_EQ(tok[1], -1, -1, 0)); + check(p.toknext == 1); js = "\"x\": \"valu"; r = jsmn_parse(&p, js, tok, 10); check(r == JSMN_ERROR_PART && tok[0].type == JSMN_STRING); check(TOKEN_STRING(js, tok[0], "x")); - check(TOKEN_EQ(tok[1], -1, -1, 0)); + check(p.toknext == 1); js = "\"x\": \"value\""; r = jsmn_parse(&p, js, tok, 10);